Comments on: Quick Tip: Get, Set and Query in One Method http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/ Stuart Herbert's PHP Blog - Architecture, Code, and Hosting Fri, 20 Aug 2010 11:10:43 +0000 http://wordpress.org/?v=2.9.2 hourly 1 By: M L http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/comment-page-1/#comment-15215 M L Fri, 22 Feb 2008 16:15:06 +0000 http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/#comment-15215 It benchmarked at about 3 times longer than your method. Not a nice trade-off for readability. But traditional getX and setX methods were faster than your single method and don't have the non-null requirement for the property. Could you clarify the difference between query and get? It seems to me that your code acts like a getCanCache method when you don't pass any parameters (or pass null) and acts like a setCanCache when you do. It benchmarked at about 3 times longer than your method. Not a nice trade-off for readability. But traditional getX and setX methods were faster than your single method and don’t have the non-null requirement for the property.

Could you clarify the difference between query and get? It seems to me that your code acts like a getCanCache method when you don’t pass any parameters (or pass null) and acts like a setCanCache when you do.

]]> By: Stu http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/comment-page-1/#comment-15177 Stu Fri, 22 Feb 2008 07:30:45 +0000 http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/#comment-15177 @M L: what's the performance cost of doing it that way? How do you support the tristate syntax I put forward in my original example? Best regards, Stu @M L: what’s the performance cost of doing it that way? How do you support the tristate syntax I put forward in my original example?

Best regards,
Stu

]]> By: M L http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/comment-page-1/#comment-15143 M L Fri, 22 Feb 2008 00:39:34 +0000 http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/#comment-15143 Here is what I was getting at: class HidingExample { private $_SomeProperty; private function getSomeProperty() { //custom code... return $this->_SomeProperty; } private function setSomeProperty($value) { //custom code... $this->_SomeProperty = $value; } public function __get($name) { $methodName = "get$name"; if (method_exists($this, $methodName)) return $this->$methodName(); //do catch all stuff here } public function __set($name, $value) { $methodName = "set$name"; if (method_exists($this, $methodName)) return $this->$methodName($value); //do catch all stuff here } } Here is what I was getting at:

class HidingExample
{
private $_SomeProperty;

private function getSomeProperty()
{
//custom code…
return $this->_SomeProperty;
}

private function setSomeProperty($value)
{
//custom code…
$this->_SomeProperty = $value;
}

public function __get($name)
{
$methodName = “get$name”;

if (method_exists($this, $methodName))
return $this->$methodName();

//do catch all stuff here
}

public function __set($name, $value)
{
$methodName = “set$name”;

if (method_exists($this, $methodName))
return $this->$methodName($value);

//do catch all stuff here
}
}

]]> By: Stu http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/comment-page-1/#comment-15106 Stu Thu, 21 Feb 2008 17:02:01 +0000 http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/#comment-15106 @M L: __get and __set are great as a general catch-all, but they quickly become unmaintainable if you need different behaviour for each of the attributes that you are hiding. @M L: __get and __set are great as a general catch-all, but they quickly become unmaintainable if you need different behaviour for each of the attributes that you are hiding.

]]> By: M L http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/comment-page-1/#comment-15104 M L Thu, 21 Feb 2008 16:04:04 +0000 http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/#comment-15104 The null restriction is enough to discourage this method. Why not use the member overload methods __get and __set? With reflection, it could be made even more robust by looking up a private get/set method. The null restriction is enough to discourage this method.

Why not use the member overload methods __get and __set? With reflection, it could be made even more robust by looking up a private get/set method.

]]> By: Kirrus http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/comment-page-1/#comment-10138 Kirrus Mon, 17 Dec 2007 16:27:42 +0000 http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/#comment-10138 As in, what does the "->" do in the statement? (Just realised I hadn't made clear what I was asking :S) As in, what does the “->” do in the statement?
(Just realised I hadn’t made clear what I was asking :S)

]]> By: Kirrus http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/comment-page-1/#comment-9981 Kirrus Fri, 14 Dec 2007 10:41:24 +0000 http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/#comment-9981 Hello, I've only worked on php at a low-level (made a website, altered some php code for another), so I'm a bit of a Newbie when it comes to php.. I hope you don't mind me asking, but I see this sort of expression a lot nowadays, and was wondering if you could tell me what it means? $this->canCache = false; Hello,
I’ve only worked on php at a low-level (made a website, altered some php code for another), so I’m a bit of a Newbie when it comes to php..

I hope you don’t mind me asking, but I see this sort of expression a lot nowadays, and was wondering if you could tell me what it means?

$this->canCache = false;

]]> By: developercast.com » Stuart Herbert’s Blog: Quick Tip: Get, Set and Query in One Method http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/comment-page-1/#comment-9908 developercast.com » Stuart Herbert’s Blog: Quick Tip: Get, Set and Query in One Method Wed, 12 Dec 2007 21:17:26 +0000 http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/#comment-9908 [...] his blog, Stuart Herbert has a quick tip showing how to mimic a feature of Ruby on Rails: I’m still working on the next article in [...] [...] his blog, Stuart Herbert has a quick tip showing how to mimic a feature of Ruby on Rails: I’m still working on the next article in [...]

]]> By: ctx2002 http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/comment-page-1/#comment-9811 ctx2002 Mon, 10 Dec 2007 21:42:09 +0000 http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/#comment-9811 this code has many side effect when you passing different value into canCache($newState = null) function. i have no ruby experience , but why you want to do many things in one method seems violate an important programming principal. "an function only do one thing and do it well." this code has many side effect when you passing different value into canCache($newState = null) function.

i have no ruby experience , but why you want to do many things in one method seems violate an important programming principal. “an function only do one thing and do it well.”

]]> By: Pierre http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/comment-page-1/#comment-9797 Pierre Mon, 10 Dec 2007 15:26:33 +0000 http://blog.stuartherbert.com/php/2007/12/10/quick-tip-get-set-and-query-in-one-method/#comment-9797 I prefer KISS, and that's not simple. People who see calls to canCache() with false, null or true or no arguments several times in one file on several circumstances would be confused if they don't know what that method does exactly. I prefer KISS, and that’s not simple. People who see calls to canCache() with false, null or true or no arguments several times in one file on several circumstances would be confused if they don’t know what that method does exactly.

]]>